Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): long running operation recovery #882

Merged
merged 19 commits into from
Jan 3, 2025

Conversation

Sotatek-TungNguyen2a
Copy link
Collaborator

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a commented Dec 23, 2024

Description

When recovering on a new device, we need to recover any long running operations that are currently on-going. Checking also allows us to know if e.g. an identifier is pending or not.

linkedGroupRequest is now linkedRequest and is also used to track single-sig/individual IPEX so we can recover. Before, we deleted any notification related to individual IPEX once the long running operation was tracked, but a hidden flag has been introduced on the notification record to temporarily hide it in the UI. It also then gets deleted once the long running operation completes, like multi-sig/group IPEX.

Not applicable to connections/contacts since the contacts only appear once complete anyway. Any pending connections will be lost in recovery and this is acceptable.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1583

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a self-assigned this Dec 23, 2024
@Sotatek-TungNguyen2a Sotatek-TungNguyen2a changed the title feat(core0: long running operation recovery feat(core): long running operation recovery Dec 23, 2024
@iFergal iFergal requested a review from jimcase January 2, 2025 22:30
@iFergal iFergal merged commit ecb326c into develop Jan 3, 2025
1 check passed
@iFergal iFergal deleted the feat/DTIS-1583-long-running-operation-recovery branch January 3, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants