-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): long running operation recovery #882
Merged
iFergal
merged 19 commits into
develop
from
feat/DTIS-1583-long-running-operation-recovery
Jan 3, 2025
Merged
feat(core): long running operation recovery #882
iFergal
merged 19 commits into
develop
from
feat/DTIS-1583-long-running-operation-recovery
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-record-to-mark-restore-as-complete
…ic-record-to-mark-restore-as-complete
…ic-record-to-mark-restore-as-complete
…ic-record-to-mark-restore-as-complete
Sotatek-TungNguyen2a
requested review from
jimcase and
iFergal
as code owners
December 23, 2024 08:15
Sotatek-TungNguyen2a
changed the title
feat(core0: long running operation recovery
feat(core): long running operation recovery
Dec 23, 2024
jimcase
reviewed
Dec 23, 2024
iFergal
reviewed
Dec 30, 2024
…g-running-operation-recovery
…g-running-operation-recovery
iFergal
reviewed
Jan 2, 2025
jimcase
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When recovering on a new device, we need to recover any long running operations that are currently on-going. Checking also allows us to know if e.g. an identifier is pending or not.
linkedGroupRequest
is nowlinkedRequest
and is also used to track single-sig/individual IPEX so we can recover. Before, we deleted any notification related to individual IPEX once the long running operation was tracked, but ahidden
flag has been introduced on the notification record to temporarily hide it in the UI. It also then gets deleted once the long running operation completes, like multi-sig/group IPEX.Not applicable to connections/contacts since the contacts only appear once complete anyway. Any pending connections will be lost in recovery and this is acceptable.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review